feat: add download button to FileViewer header#347
Merged
allison-truhlar merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
Adds a download icon button (HiOutlineDownload) to the FileViewer header for all files. Uses getFileURL to construct the content URL and the HTML download attribute to trigger a browser download with the correct filename. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a download icon button to the
FileViewerheader for all files. Clicking it triggers a browser download with the correct filename via the HTMLdownloadattribute.getFileURL(fspName, file.path)to construct the content URLHiOutlineDownloadfromreact-icons/hifor the iconTest plan
pixi run node-check— no TypeScript errorspixi run node-eslint-check— no ESLint errors🤖 Generated with Claude Code