Repository navigation
fix: preserve audio gain in timeline exports - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeline export reduced audible clip volume according to unrelated delayed audio inputs. This change preserves timeline gains and adds a non-boosting peak limiter with compensated lookahead.
This is the same generic fix proposed upstream in BeatAPI#24 for BeatAPI#23 . Local narration/model adaptations are separate.
Two FFmpeg regression tests pass: sequential clips keep unity gain; overlapping loud inputs stay bounded without changing duration. Typecheck, i18n and production build pass on the upstream baseline. The upstream baseline's existing Windows portability failures are documented in upstream PR BeatAPI#24. No generated media, credentials or machine configuration are included.