Skip to content

project support#27

Open
Lev Shagalov (Lewik) wants to merge 1 commit into
JetBrains:masterfrom
Lewik:master
Open

project support#27
Lev Shagalov (Lewik) wants to merge 1 commit into
JetBrains:masterfrom
Lewik:master

Conversation

@Lewik

Copy link
Copy Markdown

Seems this work for me on demo project. Will check it at work (I had issues with multiple projects/modules).

override fun execute(urlDecoder: QueryStringDecoder, request: FullHttpRequest, context: ChannelHandlerContext): String? {
val path = urlDecoder.path().split(serviceName).last().trimStart('/')
val project = getLastFocusedOrOpenedProject() ?: return null

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line can be removed

@Serializable
object NoArgs

interface ProjectAware {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide a java doc for this interface? This is needed to better understand the meaning behind this interface

@Serializable
data class PropertySchema(
val type: String
val type: String,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this modification?

@hjed

Copy link
Copy Markdown

Any update on this getting merged - probably the biggest impact issue with this MCP. As it prevents using multiple projects at once

@Lewik

Copy link
Copy Markdown
Author

Harry J E Day (@hjed) you can fix =) (do you?)
Also please check it locally too

@hjed

Copy link
Copy Markdown

Have the review comments done on a branch master...hjed:mcp-server-plugin:project-aware but haven't had chance to test more extensively

@hjed

Copy link
Copy Markdown

after testing have now raised an updated pr

@Lewik

Copy link
Copy Markdown
Author

Is this PR still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants