feat: add Obsidian frontmost note support - #263
Draft
johnyoonh wants to merge 1 commit into
Draft
Conversation
feat: add Obsidian CLI support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
OpenInTerminal checks Obsidian's bundled
obsidian-clifirst, then common Homebrew CLI locations. If the CLI is unavailable, cannot resolve the active file, or the resolved file does not exist under the active vault, OpenInTerminal falls back to the existing Finder-based behavior.Verification
xcrun swiftc -typecheck OpenInTerminalCore/*.swift OpenInTerminalCore/Extensions/*.swift OpenInTerminalCore/ScriptingBridge/*.swiftgit diff --checkxcodebuild -workspace OpenInTerminal.xcworkspace -scheme OpenInTerminal -configuration Debug -destination 'platform=macOS,arch=arm64' -derivedDataPath /tmp/OpenInTerminalDerivedDataCli CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO build\n- Manual: with Obsidian frontmost and an active note in a nested directory, Ctrl+Shift+Cmd+O opened Terminal in the active note parent directory\n- Manual: direct iTerm launch created an iTerm window in the active note parent directory\n- Manual: editor launch generated an open command targeting the active note file\n