feat: add Otty terminal support - #276
Open
pintaste wants to merge 1 commit into
Open
Conversation
Register Otty (https://otty.sh/) as a first-class terminal, same way as Ghostty/cmux: SupportedApps entry + icon + docs. Otty declares public.folder support, so the generic open -a path works safely with discrete Process arguments (no shell interpolation). Also rename the existing otty icon imageset to Otty so NSImage(named:) matches the app name, refresh the icon from Otty.app, and fix the Lite-zh Ghostty defaults example casing.
|
Independent verification on macOS with Otty 1.2.3:
This looks ready from the Otty integration side. The only PR-template follow-up I noticed is linking the existing request with Closes #266. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add first-class support for Otty terminal.
This follows the same pattern as Ghostty / cmux / Kaku:
OttyinSupportedApps(bundle idio.appmakes.otty)ottyimageset — renamed toOttyto match the app name, icon refreshed fromOtty.app)How opening works
Otty registers
public.folderas a document type, so the existing safe path works:No custom shell string, no AppleScript path interpolation — same injection-safe discrete-argument approach used after the recent security fix.
Lite: set Otty as default
Test plan
xcodebuildOpenInTerminalCore — BUILD SUCCEEDEDxcodebuildOpenInTerminal — BUILD SUCCEEDEDxcodebuildOpenInTerminal-Lite — BUILD SUCCEEDEDxcodebuildOpenInEditor-Lite — BUILD SUCCEEDEDSupportedApps.from("Otty"), type, bundle id,getOpenArguments→["-a", "Otty"]open -a Ottywith normal path, path with spaces/quotes, and a shell-injection-looking path (no injection file created)LiteDefaultTerminal=Ottyopens/tmp/...viaopen -a Otty ...(exit 0)Manual check for reviewers
/Applications/Otty.appNotes
otty.