Fix preferences, shortcuts, login launch, and Finder extension on macOS 27 - #281
Open
chillednems wants to merge 3 commits into
Open
Fix preferences, shortcuts, login launch, and Finder extension on macOS 27#281chillednems wants to merge 3 commits into
chillednems wants to merge 3 commits into
Conversation
chillednems
marked this pull request as ready for review
July 29, 2026 19:55
Author
|
I have a build of the app in the fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SMAppService.mainAppon macOS 13 and newer while preserving the legacy helper for older releases/in the FinderSync monitored scope and providing safe fallback actionsRoot causes
The main app and Finder extension used
group.wang.jianing.app.OpenInTerminalunconditionally.UserDefaults(suiteName:)can return an object even when the process cannot access the corresponding container, which made writes appear successful without remaining durable. The updated code uses the Team-prefixed App Group for official builds, verifies the current signing Team ID and container access, and falls back to the process's standard defaults domain for ad-hoc or differently signed builds.Shortcut actions were only added to
GlobalShortcutMonitorwhen a shortcut was already non-nil. That prevented ShortcutRecorder from observing actions configured after launch.Launch at login relied only on deprecated
SMLoginItemSetEnabled, and the compatibility helper checked an incorrect main-app bundle identifier. Modern systems now useSMAppService.mainAppand surface the system approval state.The Finder extension depended entirely on visible mounted-volume enumeration. On macOS 27 it could be enabled and running while having no useful Finder scope. The extension now always includes
/, adds other visible volumes, and no longer returns an empty menu when shared preferences are unavailable. The containing app's obsoleteNSExtensiondeclaration was also removed; the declaration remains on the embedded.appex.Validation
Local checks:
arm64andx86_64executablesDevice validation on macOS 27.0 beta (
26A5388g, Apple silicon):Remaining signing validation
The test artifact is ad-hoc signed and therefore has no Team ID. It correctly exercises the standard-defaults fallback, but it cannot access the upstream App Group. Please rebuild with the existing
C8VX3ZLX5UDeveloper ID identity and confirm that the main app and Finder extension share the selected terminal and editor throughC8VX3ZLX5U.wang.jianing.app.OpenInTerminal.