feat: add date-range filter to group activity feed#138
Merged
Sendi0011 merged 2 commits intoJun 27, 2026
Merged
Conversation
- Add From/To date inputs above the activity list in group-activity.tsx - Filter displayed activities to the selected date range (inclusive, full-day bounds) covering both on-chain and Supabase-sourced events - Clearing the filter restores the full unfiltered feed - Pagination resets to page 1 on every filter change so Load more always works correctly within the filtered result set - Empty state message distinguishes no-activity from no-results-in-range - applyDateFilter is a pure function for easy unit testing Closes JointSave-org#129
Author
|
Hi Maintainer Please check the PR out |
Sendi0011
reviewed
Jun 27, 2026
Sendi0011
left a comment
Sendi0011
left a comment
Contributor
There was a problem hiding this comment.
@Yasir-TechGuy I Love the date filter logic — the end-of-day bound on the "to" date and resetting pagination on filter change are both really thoughtful touches. Found one small thing: around the transaction link rendering further down in the file, the <a tag itself seems to have gotten dropped (the attributes — href, target, etc. — are all there, just missing the opening tag). Easy fix, just needs that line restored. Once that's in, this looks great.
Author
|
@Sendi0011 Thanks, i will solve it ASAP |
Author
|
@Sendi0011 Done! |
Contributor
Thanks for swift response 👍 |
Sendi0011
reviewed
Jun 27, 2026
Sendi0011
left a comment
Sendi0011
left a comment
Contributor
There was a problem hiding this comment.
This looks great! Merging right away
3 tasks
Author
|
@Sendi0011 Nice Workig with u! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a From/To date-range picker above the activity list in
group-activity.tsxso users can filter the feed to a specific period without paging through everything chronologically.applyDateFilteris a pure function for easy unit testingCloses #129
Type of Change
How Has This Been Tested?
pnpm buildsucceeds (frontend) — pre-existingpapaparseerror confirmed unrelated to this PRpnpm lintpasses (frontend) — no errors on changed fileManual testing performed:
Checklist
closes #129