Skip to content

Add low member count warning for rotational pools#153

Merged
Sendi0011 merged 1 commit into
JointSave-org:mainfrom
khanavi272-spec:feat/low-member-count-warning
Jun 27, 2026
Merged

Add low member count warning for rotational pools#153
Sendi0011 merged 1 commit into
JointSave-org:mainfrom
khanavi272-spec:feat/low-member-count-warning

Conversation

@khanavi272-spec

Copy link
Copy Markdown
Contributor

Description

This PR adds a non-blocking warning banner to the Rotational Pool detail page when the pool member count falls to 2 or fewer.

The banner informs users that the pool has very few members remaining and suggests inviting more members or planning for a shorter cycle.

Closes #150

Type of Change

  • feat: new feature
  • fix: bug fix
  • chore: maintenance, tooling, dependencies
  • docs: documentation only
  • refactor: code restructuring (no functional changes)
  • test: adding or updating tests

How Has This Been Tested?

  • cargo test passes (smart contracts)
  • pnpm build succeeds (frontend)
  • pnpm lint passes (frontend)
  • Manual testing

Manual Testing

  • Verified the warning banner is displayed for rotational pools with 2 or fewer members.
  • Verified the banner is informational only and does not block any pool actions.
  • Verified pools with more than 2 members are unaffected.

Checklist

  • My code follows the project's coding style.
  • I have reviewed my own code.
  • I have kept the change focused on the requested feature.

Closes #147

@Sendi0011 Sendi0011 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khanavi272-spec Nice, clean addition — really like that this is scoped specifically to Rotational pools, since that's where a missing deposit really does hit harder with fewer members. Reusing the existing members_count field and matching the existing warning-banner style (like the paused-pool one) instead of inventing something new is exactly right. One tiny non-blocking thing: a couple of the new lines have slightly different indentation than the rest of the file — might be worth a quick formatter pass, but not something I'd hold this up for. Approving!

@Sendi0011 Sendi0011 merged commit 9483f62 into JointSave-org:main Jun 27, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants