Consolidate duplicate _with_custom_depth serialization methods#11
Merged
johngallagher merged 1 commit intoMar 9, 2026
Merged
Conversation
The four *_with_custom_depth methods (serialize_argument, serialize_hash, serialize_array, serialize_object) were near-identical copies of the base methods, differing only in whether max_depth was computed from config or passed explicitly. Unified into a single family using an optional max_depth parameter (nil = compute from config, value = use as-is and propagate down). Removes ~65 lines of duplicated code. https://claude.ai/code/session_01KWZUse79XR68i6nGa8VgTu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the four
*_with_custom_depthmethods and merges their logic into the main serialization methods via an optionalmax_depthparameter, eliminating the duplication.