Extract CallerInformation and ArgumentExtractor to module-level files#12
Open
johngallagher wants to merge 1 commit into
Open
Extract CallerInformation and ArgumentExtractor to module-level files#12johngallagher wants to merge 1 commit into
johngallagher wants to merge 1 commit into
Conversation
Both were nested inside Instrumenter, making them inaccessible outside and tightly coupling them to Instrumenter's implementation. Moving them to their own files (caller_information.rb, argument_extractor.rb) under Observable:: makes them independently testable and reusable. Also takes the opportunity to fix the unused local_variables call and bare rescue in ArgumentExtractor (fixes already done in sibling PRs). https://claude.ai/code/session_01KWZUse79XR68i6nGa8VgTu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the nested
CallerInformationstruct andArgumentExtractorclass out ofInstrumenterinto their own files (caller_information.rbandargument_extractor.rb) to improve organisation and reduce nesting.