Replaces DeviceDNA client details with SDK-native deviceDetails payload - #356
Conversation
| val countryCode: String?, | ||
| val cultureLocale: String?, | ||
| val os: String?, | ||
| ) |
There was a problem hiding this comment.
Looking into Android DeviceDNA, it seems that over there we gather more parameters than those in this list here.
Is it intended? We are not supposed to send everything we are gathering at the moment by DeviceDNA?
There was a problem hiding this comment.
This is intentional — we deliberately limited the props to the subset the backend consumes, to avoid passing unused data. You can check CT-3269 for details.
| get() = METHOD_POST == method | ||
| // A one-shot body cannot be buffered here and then written again when the request is sent. | ||
| private val RequestBody.isRewritableJson: Boolean | ||
| get() = !isOneShot() && contentType()?.subtype == "json" |
There was a problem hiding this comment.
I believe it would be beneficial to add 1-sentence comment about 'one-shot' case (what is and when is expected).
…p-device-dna-dependency
|
4 participants
No description provided.