Add BlockedUnitRangeFirsts/Lasts to avoid allocating#509
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 94.39% 0.00% -94.40%
==========================================
Files 19 20 +1
Lines 1821 1850 +29
==========================================
- Hits 1719 0 -1719
- Misses 102 1850 +1748 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@mtfishman it will be a while before the coverage is up and all the tests are passing. But perhaps you can have a preliminary look at this? This is fixing two previous issues:
Any general thoughts about the design would be useful. I'm not convinced with my current naming scheme. And note that |
This introduces a special type to avoid allocations in
blockfirsts/blocklengths. It also removes a hack for rangedblocklaststhat didn't work when the first index wasn't consistent by introducing a special range typeFirstStepRangeLenwhen the first index matches the step.