Skip to content

Trying to allow Int8 as indices#371

Open
simone-silvestri wants to merge 19 commits into
JuliaArrays:masterfrom
simone-silvestri:master
Open

Trying to allow Int8 as indices#371
simone-silvestri wants to merge 19 commits into
JuliaArrays:masterfrom
simone-silvestri:master

Conversation

@simone-silvestri

Copy link
Copy Markdown

This PR is trying to solve #370. This is just an initial proposal, but I guess there is a lot of work to do still.
I have noticed that

julia> BigInt(1) !== BigInt(1)
true

so I had to manually change some tests when the offsets are BigInts

Any suggestion or comment is more than welcome as I am not very sure about downstream implications of this PR

@codecov

codecov Bot commented Jan 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.62%. Comparing base (f9fd311) to head (b645e13).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   96.57%   96.62%   +0.05%     
==========================================
  Files           6        6              
  Lines         467      474       +7     
==========================================
+ Hits          451      458       +7     
  Misses         16       16              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano giordano left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer the decision about adding a new type parameter to the maintainers of the package

Comment thread ext/OffsetArraysAdaptExt.jl Outdated
Comment thread src/OffsetArrays.jl
Comment thread src/OffsetArrays.jl Outdated
Comment thread src/OffsetArrays.jl Outdated
simone-silvestri and others added 6 commits May 1, 2026 17:59
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants