Widen DataStructures compat: "^0.18" → "0.18, 0.19"#117
Merged
jkaye2012 merged 2 commits intoMay 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The narrow upper bound on
DataStructures = "^0.18"prevents Redis.jl from composing with packages whose transitive dep chain pulls DataStructures 0.19+. In particular, anything in the SciML/MTK ecosystem at ModelingToolkitBase 1.x → Symbolics 7 → MultivariatePolynomials 0.5 → DataStructures 0.19 currently fails Pkg resolve with an unsatisfiable graph when Redis.jl is also in the project.Redis.jl's actual usage of DataStructures is
OrderedDict/etc. — API-stable across the 0.18 → 0.19 boundary (no breaking changes between those minors that affect the patterns this package uses). Widening to"0.18, 0.19"is a no-op functionally and unblocks a broad class of downstream compositions.This was applied as a fork-branch in
RiftSim/Redis.jland verified end-to-end in the riftsim API service — 68 deps precompile clean against MTKBase 1.40 + Symbolics 7.24 + Redis fork, with Redis's connection / pub-sub / pipeline / transaction code paths exercised through the worker queue.Diff
Single line in
Project.toml [compat]. No code touched.Test
Upstream's existing test suite passes locally with the widened compat. Happy to add a CI matrix entry for DataStructures 0.19 if useful.
Note
Base of this PR is upstream tagged v3.0.0, NOT current master. The unreleased changes on master (cluster support, etc.) tripped a precompile method-overwrite check in our environment on Julia 1.11.8 — that's a separate issue and likely orthogonal to this fix. Happy to rebase onto master and investigate, or have you land this on a v3.0.x maintenance branch first.
Thanks for maintaining the package.