Add PrecomposedSlicedSeparableSum implementation and corresponding tests#157
Add PrecomposedSlicedSeparableSum implementation and corresponding tests#157hakkelt wants to merge 3 commits intoJuliaFirstOrder:masterfrom
Conversation
d947f82 to
da2eaa3
Compare
|
@lostella: Could you review this PR? The benchmarking is still failing because of the lack of permission. 😞 My guess is that adding write permisison to workflows (Settings -> Actions -> General -> Workflow permissions -> Read repository contents and packages permissions) might solve the problem. I'm not really expert on security, so I'm not sure how dangerous it is exactly. What I read about that is that it can lead to exposure of secrects (e.g. if someone creates a PR that modifies the benchmarking script such that it sends the GITHUB_TOKEN to an external server). But as your approval is required for PRs of new contributors by the current settings, the threat is greatly reduced, I think. The other option could be to disable commenting and push the results only to job summary (https://astroautomata.com/AirspeedVelocity.jl/stable/#Option-2:-Job-Summary). |
|
@hakkelt will review asap. I agree that probably disabling comments from the benchmarking workflow, and logging the result instead, is the safest at the moment. Does the workflow fail in case of performance regressions? If so, that should be enough: red => inspect logs |
This new function implements the intersection/composition of Precompose and SlicedSeparableSum. The long name suggests a code smell, but I could not find a cleaner way to implement this composition, so I'm open to better solutions. The goal is to implement prox for tricky expressions like the following: