Benchmarking results as job summary#158
Draft
hakkelt wants to merge 1 commit intoJuliaFirstOrder:masterfrom
Draft
Benchmarking results as job summary#158hakkelt wants to merge 1 commit intoJuliaFirstOrder:masterfrom
hakkelt wants to merge 1 commit intoJuliaFirstOrder:masterfrom
Conversation
Member
|
I think it looks ok. Needs clicking around to discover it, but it’s fine. My guess though is that the workflow will never fail, even in case of regressions? |
Contributor
Author
|
Yes, the job only fails in case of error. I'm thinking about appending a small script to the workflow that checks the results (possibly I'll refurbish some parts from the previous benchmarking solution), and throws error when regressions are detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see what it looks like if benchmarking results are saved as a job summary...