-
Notifications
You must be signed in to change notification settings - Fork 8
use reusable workflow #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,138 +1,7 @@ | ||
| # Ref: https://securitylab.github.com/research/github-actions-preventing-pwn-requests | ||
| name: Breakage | ||
|
|
||
| # read-only repo token | ||
| # no access to secrets | ||
| on: | ||
| pull_request: | ||
|
|
||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| jobs: | ||
| # Build dynamically the matrix on which the "break" job will run. | ||
| # The matrix contains the packages that depend on ${{ env.pkg }}. | ||
| # Job "setup_matrix" outputs variable "matrix", which is in turn | ||
| # the output of the "getmatrix" step. | ||
| # The contents of "matrix" is a JSON description of a matrix used | ||
| # in the next step. It has the form | ||
| # { | ||
| # "pkg": [ | ||
| # "PROPACK", | ||
| # "LLSModels", | ||
| # "FletcherPenaltySolver" | ||
| # ] | ||
| # } | ||
| setup_matrix: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| matrix: ${{ steps.getmatrix.outputs.matrix }} | ||
| env: | ||
| pkg: ${{ github.event.repository.name }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: 1 | ||
| arch: x64 | ||
| - id: getmatrix | ||
| run: | | ||
| julia -e 'using Pkg; Pkg.Registry.add(RegistrySpec(url = "https://github.com/JuliaRegistries/General.git"))' | ||
| julia --project=.breakage -e 'using Pkg; Pkg.update(); Pkg.instantiate()' | ||
| pkgs=$(julia --project=.breakage .breakage/get_jso_users.jl ${{ env.pkg }}) | ||
| vs='["latest", "stable"]' | ||
| # Check if pkgs is empty, and set it to a JSON array if necessary | ||
| if [[ -z "$pkgs" || "$pkgs" == "String[]" ]]; then | ||
| echo "No packages found; exiting successfully." | ||
| exit 0 | ||
| fi | ||
| vs='["latest", "stable"]' | ||
| matrix=$(jq -cn --argjson deps "$pkgs" --argjson vers "$vs" '{pkg: $deps, pkgversion: $vers}') # don't escape quotes like many posts suggest | ||
| echo "matrix=$matrix" >> "$GITHUB_OUTPUT" | ||
|
|
||
| break: | ||
| needs: setup_matrix | ||
| if: needs.setup_matrix.result == 'success' && needs.setup_matrix.outputs.matrix != '' | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: ${{ fromJSON(needs.setup_matrix.outputs.matrix) }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| # Install Julia | ||
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: 1 | ||
| arch: x64 | ||
| - uses: actions/cache@v4 | ||
| env: | ||
| cache-name: cache-artifacts | ||
| with: | ||
| path: ~/.julia/artifacts | ||
| key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-test-${{ env.cache-name }}- | ||
| ${{ runner.os }}-test- | ||
| ${{ runner.os }}- | ||
| - uses: julia-actions/julia-buildpkg@v1 | ||
|
|
||
| # Breakage test | ||
| - name: 'Breakage of ${{ matrix.pkg }}, ${{ matrix.pkgversion }} version' | ||
| env: | ||
| PKG: ${{ matrix.pkg }} | ||
| VERSION: ${{ matrix.pkgversion }} | ||
| run: | | ||
| set -v | ||
| mkdir -p ./breakage | ||
| git clone https://github.com/JuliaSmoothOptimizers/$PKG.jl.git | ||
| cd $PKG.jl | ||
| if [ $VERSION == "stable" ]; then | ||
| TAG=$(git tag -l "v*" --sort=-creatordate | head -n1) | ||
| if [ -z "$TAG" ]; then | ||
| TAG="no_tag" | ||
| else | ||
| git checkout $TAG | ||
| fi | ||
| else | ||
| TAG=$VERSION | ||
| fi | ||
| export TAG | ||
| julia -e 'using Pkg; | ||
| PKG, TAG, VERSION = ENV["PKG"], ENV["TAG"], ENV["VERSION"] | ||
| joburl = joinpath(ENV["GITHUB_SERVER_URL"], ENV["GITHUB_REPOSITORY"], "actions/runs", ENV["GITHUB_RUN_ID"]) | ||
| open("../breakage/breakage-$PKG-$VERSION", "w") do io | ||
| try | ||
| TAG == "no_tag" && error("No tag for $VERSION") | ||
| pkg"activate ."; | ||
| pkg"instantiate"; | ||
| pkg"dev ../"; | ||
| if TAG == "latest" | ||
| global TAG = chomp(read(`git rev-parse --short HEAD`, String)) | ||
| end | ||
| pkg"build"; | ||
| pkg"test"; | ||
|
|
||
| print(io, "[]($joburl)"); | ||
| catch e | ||
| @error e; | ||
| print(io, "[]($joburl)"); | ||
| end; | ||
| end' | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: breakage-${{ matrix.pkg }}-${{ matrix.pkgversion }} | ||
| path: breakage/breakage-* | ||
|
|
||
| upload_pr_number: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Write PR number | ||
| run: | | ||
| mkdir -p breakage-pr-number | ||
| echo "${{ github.event.pull_request.number }}" > breakage-pr-number/pr-number.txt | ||
|
|
||
| - name: Upload PR number artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: pr-number | ||
| path: breakage-pr-number/pr-number.txt | ||
| breakage: | ||
| uses: MaxenceGollier/.github_JSO/.github/workflows/Breakage.yml@comment | ||
|
Comment on lines
+6
to
+7
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation under
on:is inconsistent with the rest of the repo’s workflows (they use two-space indentation). Consider reformatting this block to the standard layout to avoid YAML readability issues and keep workflow files consistent.