Record a failing @test_logs as a failure instead of erroring#64
Open
JohnCobbler wants to merge 2 commits into
Open
Record a failing @test_logs as a failure instead of erroring#64JohnCobbler wants to merge 2 commits into
JohnCobbler wants to merge 2 commits into
Conversation
A failing @test_logs produces a Test.LogTestFailure, which is not a Fail/Error/Broken, so ReTestSet has no record method for it and the failure throws a MethodError instead of being reported. Convert it to a Fail in record, as Test.DefaultTestSet does, so it is counted and printed like any other failure. Co-authored-by: Claude <noreply@anthropic.com>
Integration module FailingTestLogs asserts retest throws TestSetException instead of MethodError when @test_logs fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failing
@test_logsproduces aTest.LogTestFailure, which is not aFail/Error/Broken, soReTestSethad norecordmethod for it and thefailure threw a
MethodErrorinstead of being reported.Convert
LogTestFailuretoFailinrecord, matchingTest.DefaultTestSet, so it is counted and printed like any other failure.Adds a unit test on
record/anyfailed/get_test_counts, and an integrationmodule whose failing
@test_logscausesretestto throwTestSetException(not
MethodError).Fixes #50