Common: log a note instead of dump content to console#133
Merged
Conversation
The hexdump (and potential disassembly) content was printed into the message console although both have dedicated debugger views. The long unwrapped dump lines were also the reason the console needed a horizontal scrollbar, which does not mirror well in RTL locales (#129). Log a short translated "Hexdump generated." note instead, let the console wrap messages and drop its horizontal scrollbar. Fixes #129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129
Problem
The horizontal scrollbar of the message console did not behave RTL-correctly. The scrollbar only existed because the full hexdump content (long, unwrappable lines,
wrap-mode: none) was printed into the console — even though the hexdump and disassembly each have a dedicated debugger view showing the same content.Fix
Hexdump generated./Disassembly generated.) instead of the dump content; the dedicated views keep showing the dumps viaupdateAssemblerViews.wrap-mode: word_char) and never shows a horizontal scrollbar (hscrollbar-policy: never) — with wrapping, horizontal scrolling has no remaining use, and vertical scrolling mirrors fine in RTL..pofiles validated withmsgfmt --check.The previous
"Hexdump:\n%s"/"Disassembly:\n%s"msgids from #127 are obsolete and were retired by the translations build.