Skip to content

Require ARM endpoint for Azure Stack login validation#14

Draft
Jury1981 with Copilot wants to merge 2 commits into
masterfrom
copilot/update-login-validation-rules
Draft

Require ARM endpoint for Azure Stack login validation#14
Jury1981 with Copilot wants to merge 2 commits into
masterfrom
copilot/update-login-validation-rules

Conversation

Copilot AI commented Feb 4, 2026

Copy link
Copy Markdown

Azure Stack logins were allowed without providing the ARM endpoint, contradicting expected validation from the referenced change.

  • Validation

    • LoginConfig.validate now rejects environment=azurestack when resourceManagerEndpointUrl is missing.
    • New action input resource-manager-endpoint surfaces the required ARM endpoint for Azure Stack scenarios.
  • Documentation

    • README input table documents resource-manager-endpoint.
  • Tests

    • Added coverage ensuring Azure Stack requires resource-manager-endpoint; adjusted existing identity test to supply it.

Example:

- uses: Azure/login@v2
  with:
    environment: azurestack
    resource-manager-endpoint: https://management.azurestack.example.com
    auth-type: SERVICE_PRINCIPAL
    client-id: ${{ secrets.CLIENT_ID }}
    tenant-id: ${{ secrets.TENANT_ID }}
    subscription-id: ${{ secrets.SUBSCRIPTION_ID }}
Original prompt

Reference: f3ea448


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Jury1981 <210622247+Jury1981@users.noreply.github.com>
Copilot AI changed the title [WIP] Update login validation rules for better user experience Require ARM endpoint for Azure Stack login validation Feb 4, 2026
Copilot AI requested a review from Jury1981 February 4, 2026 15:14
@github-actions github-actions Bot added the Stale label Feb 18, 2026
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

This PR is idle because it has been open for 14 days with no activity.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

This PR is idle because it has been open for 14 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants