nixos/plasma6: add bigscreen session#4
Conversation
fd5b947 to
071cf3e
Compare
|
I think I got the general idea here from the review. Tested the approach again and it works. Let me know. |
|
OK so I think between this and NixOS#510025 and NixOS#459790 what's clear is that we need a "Plasma core" kind of module, and then we build on top of it to provide desktop, bigscreen and mobile as separate modules. I don't know if I have the spoons to do that refactoring right now, but I think that's the right way to go overall and I'd be happy to review it. |
1794821 to
a863fd8
Compare
a863fd8 to
98e82d7
Compare
| desk.currentConfigGroup = new Array("Wallpaper","org.kde.slideshow","General"); | ||
| desk.writeConfig("SlideInterval", 480); | ||
| - desk.writeConfig("SlidePaths", "/usr/share/wallpapers/"); | ||
| + desk.writeConfig("SlidePaths", "@wallpapers@"); |
There was a problem hiding this comment.
This should probably be /run/current-system as well, since we want to handle user installed wallpapers? (and also the user may not want 500MB of plasma-workspace-wallpapers)
| plasmaBrowserIntegrationPackage = pkgs.kdePackages.plasma-browser-integration; | ||
| }; | ||
| (mkIf cfg.bigscreen.enable { | ||
| services.desktopManager.plasma6.enable = mkDefault true; |
There was a problem hiding this comment.
I guess the next question here is, how much of plasma-desktop can we get rid of and still have a working bigscreen session? That's why I originally talked about a "core" subset, so we can have that as the lowest common denominator, and then all the other sessions building on it...
No description provided.