fix active response process identity validation#45
Merged
Conversation
Karib0u
changed the title
The active-response identity work added a process_start_time field to ProcessCreationFields and updated every constructor except the Windows-only ETW decoder (not compilable on the author's macOS host), breaking the Windows build with E0063. Populate it from creation_time_with_fallback — the same value used to build the ProcessStartKey immediately below. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merging main brought in the macOS Endpoint Security sensor (#46), whose two ProcessCreationFields constructors predate the process_start_time field and so broke the macOS build with E0063. Exec events carry the start time (reuse raw.start_time, same value as the ProcessStartKey); exit events have no start time, so None. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Active response made the termination decision from the PID and image stored in the alert context. If that PID was reused before the worker executed, termination could target a different process.
Validation
cargo test --no-runcargo test --test active_responsecargo test response::tests::validate_process_identityWindows target compile was attempted locally, but
x86_64-pc-windows-msvcis not installed on this machine.