Repository navigation
Sandboxed Rust builds on the repo LLVM are not toolchain drift (3.5.0-B145) - #11
Merged
Merged
Conversation
…drift (3.5.0-B145) In the sandbox a package that pulls Arch's rust builds with the repo LLVM that rust links, and build_sandbox.recorded_toolchain records it as stock_llvm with a sandbox| fingerprint. Phase 4.25 compared that with the host's sysforge-built toolchain, so every such package (all the COSMIC -git packages, mesa) drifted on every run and, under rebuild_on_drift, was rebuilt only to record the same stamp again. The drift loop now skips a sandbox-stamped record while flag_drift.builds_with_repo_compiler says the next build would do the same (current_sandboxed for its profile and needs_repo_rust), the B125 rule applied within one family. Turning the sandbox off for the package, or it no longer needing repo rust, reports it as before. A repo LLVM update is not detected for these packages: the sandbox's working copy is shared by every build, so its compiler identity at update time reflects the last build, not this package's next one. ID note: make next-id offered B144 on this branch, which the fix in #10 already uses, so this takes B145. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KeithRaghubar
force-pushed
the
fix/sandbox-rust-drift
branch
from
October 25, 2026 19:24
1df9efb to
aa0d8eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustbuilds with the repo LLVM that rust links, sobuild_sandbox.recorded_toolchainstamps itstock_llvmwith asandbox|fingerprint. Phase 4.25 compared that stamp with the host's sysforge-built toolchain. Every such package (all COSMIC-gitpackages,mesa) therefore drifted on every run and, underrebuild_on_drift, was rebuilt only to record the same stamp again.flag_drift.builds_with_repo_compilersays the next build would do the same (current_sandboxedfor its profile andneeds_repo_rust). This is the B125 family exemption applied within one family. A package taken out of the sandbox, or one that no longer needs repo rust, is reported as before.Merge note
PR #10 adds B144 to the same
## Fixedsection ofdocs/release-notes/unreleased.md. Whichever of the two merges second needs that conflict resolved with B144 before B145.Test plan
make test: 7666 passedtest_toolchain_drift_phase_skips_a_repo_compiler_sandbox_build(5 cases) andtest_builds_with_repo_compiler(4 cases)🤖 Generated with Claude Code