Skip to content

Add --depth option to support shallow cloning#28

Merged
kevinb-khan merged 1 commit intomasterfrom
shallow-clone
Apr 15, 2026
Merged

Add --depth option to support shallow cloning#28
kevinb-khan merged 1 commit intomasterfrom
shallow-clone

Conversation

@kevinb-khan
Copy link
Copy Markdown
Contributor

Summary:

This is to support a faster dev setup process for designers and other non-engineers wishing to vibe code experiments in Khan/frontend.

Issue: None

Test plan:

  • ka-clone --depth=1 git@github.com:Khan/webapp.git webapp2
  • see that the webapp checkout is much faster

@zaquestion
Copy link
Copy Markdown
Contributor

I had some discussion around this when I started here, but I don't think I ever followed up with any ka-clone changes. At the time @csilvers raised using --filter=blob:none to improve the clone speed, and it does reduce webapp by quite a bit, he seemed to believe it was superior to a shallow clone. If we're not already doing that, I'd suggest that we do that by default for webapp.

Copy link
Copy Markdown
Contributor

@zaquestion zaquestion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, I think we should still add a default for filterblob none. Presumably if this causes poor clones we can do some kind of repair. That said, I've got a feeling that Craig would prefer we didn't and that he has a clearer idea of the tradeoffs.

@kevinb-khan
Copy link
Copy Markdown
Contributor Author

@zaquestion we won't be using --depth=1 by default anywhere. The design team will be testing things out using --depth=1 and if they run into issue we can remove it.

@kevinb-khan kevinb-khan merged commit 3ff1be7 into master Apr 15, 2026
@kevinb-khan kevinb-khan deleted the shallow-clone branch April 15, 2026 16:43
@csilvers
Copy link
Copy Markdown
Member

@kevinb-khan it's possible that the filter is faster than --depth! In addition to not having the problems that shallow clones have. You might want to try it and replace the depth option with an option that uses the filter instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants