Skip to content

Add '--network=host' to docker build options to work around issues with #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oddhack wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add '--network=host' to docker build options to work around issues with #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions build-one.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright 2019-2024, The Khronos Group Inc.
# Copyright 2019-2026 The Khronos Group Inc.
# SPDX-License-Identifier: Apache-2.0

# Pass a Dockerfile name and version (typically the year and month).
Expand All @@ -25,11 +25,13 @@ REPO="khronosgroup/docker-images"
fi
BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')
[ -n "$CI" ] && echo "::group::$DOCKERFILE @ $VERSION"
# Use '--network=host' to work around DNS resolution in some contexts
docker build "$@" . -f "$DOCKERFILE.Dockerfile" \
--build-arg "VERSION=$VERSION" \
--label "org.opencontainers.image.created=$BUILD_DATE" \
-t "$REPO:$DOCKERFILE" \
-t "$REPO:$DOCKERFILE.$VERSION" \
--network=host \
$EXTRA_DOCKER_ARGS
if [ "$OP" == "push" ]; then
docker push "$REPO:$DOCKERFILE"
Expand All @@ -42,15 +44,18 @@ REPO="khronosgroup/docker-images"
echo
echo "** To refer to this image precisely, use:"
echo " $REPO:$DOCKERFILE.$VERSION@$HASH"

echo "After pushing an image, it is a good idea to clean up build cache and"
echo "unused images using commands like 'docker buildx prune',"
echo "'docker image ls -a --digests', and 'docker image rmi'"
else
echo
echo "** Not pushing, so no SHA256 manifest available. Until you push this image, refer to it as:"
echo " $REPO:$DOCKERFILE.$VERSION"
fi

echo "After building an image, it is a good idea to clean up build cache"
echo "and unused images using commands like:"
echo " docker buildx prune"
echo " docker image ls -a --digests"
echo " docker image rmi"


[ -n "$CI" ] && echo "::endgroup::"
)
Loading