Skip to content

layers: Fix 13357 using Image not ImageView #12280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spencer-lunarg merged 1 commit into from
May 19, 2026
+33 −11
Merged

layers: Fix 13357 using Image not ImageView #12280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions layers/core_checks/cc_image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2007,20 +2007,22 @@ bool CoreChecks::ValidateImageViewCreateInfo(const VkImageViewCreateInfo& create
}
}

if (image_flags & VK_IMAGE_CREATE_ALIAS_SINGLE_LAYER_DESCRIPTOR_BIT_KHR) {
if (vkuFormatIsMultiplane(view_format)) {
skip |= LogError("VUID-VkImageViewCreateInfo-image-13357", create_info.image, create_info_loc.dot(Field::format),
"(%s) is a multiplane format, but the image was created with flag "
"VK_IMAGE_CREATE_ALIAS_SINGLE_LAYER_DESCRIPTOR_BIT_KHR. (image flags: %s).",
string_VkFormat(view_format), string_VkImageCreateFlags(image_flags).c_str());
}
}

const bool multiplane_image = vkuFormatIsMultiplane(image_format);
if (multiplane_image) {
if (IsMultiplePlaneAspect(aspect_mask)) {
skip |= LogError("VUID-VkImageViewCreateInfo-subresourceRange-07818", create_info.image,
create_info_loc.dot(Field::subresourceRange).dot(Field::aspectMask), "(%s) is invalid for %s.",
string_VkImageAspectFlags(aspect_mask).c_str(), string_VkFormat(image_format));
}

if (image_flags & VK_IMAGE_CREATE_ALIAS_SINGLE_LAYER_DESCRIPTOR_BIT_KHR) {
skip |= LogError("VUID-VkImageViewCreateInfo-image-13357", create_info.image, create_info_loc.dot(Field::format),
"(%s) is a multiplane format, but the image was created with flag "
"VK_IMAGE_CREATE_ALIAS_SINGLE_LAYER_DESCRIPTOR_BIT_KHR. (image flags: %s).",
string_VkFormat(view_format), string_VkImageCreateFlags(image_flags).c_str());
}
}

if ((image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) && (image_format != view_format)) {
Expand Down Expand Up @@ -2065,10 +2067,11 @@ bool CoreChecks::ValidateImageViewCreateInfo(const VkImageViewCreateInfo& create
}
}
} else if (image_format != view_format) {
skip |= LogError("VUID-VkImageViewCreateInfo-image-12397", create_info.image, create_info_loc.dot(Field::format),
"%s is different from %s format (%s). Formats must be identical unless VK_IMAGE_CREATE_MUTABLE_FORMAT was "
"set on image creation.",
string_VkFormat(view_format), FormatHandle(create_info.image).c_str(), string_VkFormat(image_format));
skip |=
LogError("VUID-VkImageViewCreateInfo-image-12397", create_info.image, create_info_loc.dot(Field::format),
"%s is different from %s format (%s). Formats must be identical unless VK_IMAGE_CREATE_MUTABLE_FORMAT)BIT was "
"set on image creation.",
string_VkFormat(view_format), FormatHandle(create_info.image).c_str(), string_VkFormat(image_format));
}

if (image_state.GetSamples() != VK_SAMPLE_COUNT_1_BIT && view_type != VK_IMAGE_VIEW_TYPE_2D &&
Expand Down
19 changes: 19 additions & 0 deletions tests/unit/image_positive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,3 +945,22 @@ TEST_F(PositiveImage, BlockTexelViewLayerCount) {
// Test that VK_REMAINING_ARRAY_LAYERS evaluates to 1
vkt::ImageView view(*m_device, image_view_ci);
}

TEST_F(PositiveImage, ImageSingleLayerDescriptorFlagButMultiplanarImageView) {
AddRequiredExtensions(VK_KHR_MAINTENANCE_11_EXTENSION_NAME);
AddRequiredFeature(vkt::Feature::maintenance11);
SetTargetApiVersion(VK_API_VERSION_1_3);
RETURN_IF_SKIP(Init());

auto image_ci =
vkt::Image::ImageCreateInfo2D(128, 128, 1, 1, VK_FORMAT_G8_B8R8_2PLANE_420_UNORM, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT);
image_ci.flags |= VK_IMAGE_CREATE_ALIAS_SINGLE_LAYER_DESCRIPTOR_BIT_KHR | VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT;

vkt::Image image(*m_device, image_ci);
VkImageViewCreateInfo image_view_ci = vku::InitStructHelper();
image_view_ci.image = image;
image_view_ci.viewType = VK_IMAGE_VIEW_TYPE_2D;
image_view_ci.format = VK_FORMAT_R8_UNORM;
image_view_ci.subresourceRange = {VK_IMAGE_ASPECT_PLANE_0_BIT, 0u, 1u, 0u, VK_REMAINING_ARRAY_LAYERS};
vkt::ImageView view(*m_device, image_view_ci);
}
Loading