Skip to content

Test PBOs with a couple of invalid texSubImage2D overloads. #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenrussell merged 1 commit into from
Jun 10, 2026
Merged

Test PBOs with a couple of invalid texSubImage2D overloads. #3775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/tests/conformance2/textures/misc/00_test_list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ mipmap-fbo.html
--min-version 2.0.1 npot-video-sizing.html
--min-version 2.0.1 tex-3d-mipmap-levels-intel-bug.html
--min-version 2.0.1 origin-clean-conformance-offscreencanvas.html
--min-version 2.0.1 pbo-texture-uploads.html
tex-3d-size-limit.html
--min-version 2.0.1 tex-base-level-bug.html
--min-version 2.0.1 tex-image-10bpc.html
Expand Down
89 changes: 89 additions & 0 deletions sdk/tests/conformance2/textures/misc/pbo-texture-uploads.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
<!--
Copyright (c) 2026 The Khronos Group Inc.
Use of this source code is governed by an MIT-style license that can be
found in the LICENSE.txt file.
-->

<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>WebGL2 PBO Uploads conformance test</title>
<link rel="stylesheet" href="../../../resources/js-test-style.css"/>
<script src="../../../js/js-test-pre.js"></script>
<script src="../../../js/webgl-test-utils.js"></script>
</head>
<body>
<canvas id="example" width="32" height="32"></canvas>
<div id="description"></div>
<div id="console"></div>
<script>
"use strict";
var wtu = WebGLTestUtils;
description("Test that WebGL2 texSubImage2D overloads with bound PBO generate INVALID_OPERATION.");

var gl = wtu.create3DContext("example", undefined, 2);

if (!gl) {
testFailed("WebGL context creation failed");
} else {
runTest();
}

function runTest() {
// 1. Create a texture
var tex = gl.createTexture();
gl.bindTexture(gl.TEXTURE_2D, tex);
gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, 16, 16, 0, gl.RGBA, gl.UNSIGNED_BYTE, null);

// 2. Create and bind a PBO
var pbo = gl.createBuffer();
gl.bindBuffer(gl.PIXEL_UNPACK_BUFFER, pbo);
gl.bufferData(gl.PIXEL_UNPACK_BUFFER, 16 * 16 * 4, gl.STATIC_DRAW);

// 3. Test HTMLVideoElement overload
var video = document.createElement('video');

debug("Testing HTMLVideoElement 7-argument overload...");
gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, gl.RGBA, gl.UNSIGNED_BYTE, video);
wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION, "should generate INVALID_OPERATION when PBO is bound");

// 4. Test VideoFrame overload (if supported)
if (window.VideoFrame) {
debug("Testing VideoFrame 7-argument overload...");
var canvas = document.createElement('canvas');
canvas.width = 16;
canvas.height = 16;
var frame = new VideoFrame(canvas, {timestamp: 0});

// Without PBO, it should succeed (or at least no INVALID_OPERATION)
gl.bindBuffer(gl.PIXEL_UNPACK_BUFFER, null);
gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, gl.RGBA, gl.UNSIGNED_BYTE, frame);
var err = gl.getError();
if (err == gl.INVALID_OPERATION) {
testFailed("Should not generate INVALID_OPERATION without PBO");
} else {
testPassed("Passed without PBO");
}

// With PBO, it must fail with INVALID_OPERATION
gl.bindBuffer(gl.PIXEL_UNPACK_BUFFER, pbo);
gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, gl.RGBA, gl.UNSIGNED_BYTE, frame);
wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION, "should generate INVALID_OPERATION when PBO is bound");

frame.close();
} else {
debug("VideoFrame not supported, skipping test.");
}

// Clean up
gl.bindBuffer(gl.PIXEL_UNPACK_BUFFER, null);
gl.deleteBuffer(pbo);
gl.deleteTexture(tex);
}

var successfullyParsed = true;
</script>
<script src="../../../js/js-test-post.js"></script>
</body>
</html>
Loading