Skip to content

WEBGL_render_shared_exponent: Update color writemask validation #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenrussell merged 1 commit into from
Jul 6, 2026
Merged

WEBGL_render_shared_exponent: Update color writemask validation #3780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion extensions/WEBGL_render_shared_exponent/extension.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
name="QCOM_render_shared_exponent">
<addendum>
Clearing or drawing to a shared exponent color buffer will generate <code>INVALID_OPERATION</code>
if the associated color write mask has different values for red, green, and blue channels.
if the associated color write mask has different values for red, green, blue, and alpha channels.
</addendum>
</mirrors>

Expand All @@ -44,5 +44,8 @@ interface WEBGL_render_shared_exponent {
<revision date="2024/01/25">
<change>Promoted to Community Approved.</change>
</revision>
<revision date="2026/06/30">
<change>Adjusted color write mask validation to require the same state for all channels.</change>
</revision>
</history>
</extension>
16 changes: 13 additions & 3 deletions sdk/tests/conformance2/extensions/webgl-render-shared-exponent.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@
function expectError(enabled, effectiveMask, operation) {
if (!enabled ||
effectiveMask == 0x0 /* 0000 */ ||
effectiveMask == 0x8 /* 000A */ ||
effectiveMask == 0x7 /* RGB0 */ ||
effectiveMask == 0xF /* RGBA */ ) {
wtu.glErrorShouldBe(gl, gl.NO_ERROR, operation);
} else {
Expand Down Expand Up @@ -210,9 +208,21 @@
dbiExt.colorMaskiOES(0, true, false, false, false);
runOps(enabled, 1); // overridden

debug("Setting compatible color mask on RGB9_E5 draw buffer")
debug("Setting incompatible color mask on RGB9_E5 draw buffer")
dbiExt.colorMaskiOES(0, true, true, true, false);
runOps(enabled, 7); // overridden

debug("Setting incompatible color mask on RGB9_E5 draw buffer")
dbiExt.colorMaskiOES(0, false, false, false, true);
runOps(enabled, 8); // overridden

debug("Setting compatible color mask on RGB9_E5 draw buffer")
dbiExt.colorMaskiOES(0, false, false, false, false);
runOps(enabled, 0); // overridden

debug("Setting compatible color mask on RGB9_E5 draw buffer")
dbiExt.colorMaskiOES(0, true, true, true, true);
runOps(enabled, 15); // overridden
}
}
}
Expand Down
Loading