Skip to content

Add WebGL CTS test for active transform feedback buffer tracking #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenrussell merged 1 commit into from
Jul 9, 2026
Merged

Add WebGL CTS test for active transform feedback buffer tracking #3782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions sdk/tests/conformance2/transform_feedback/switching-objects.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,44 @@
gl.endTransformFeedback();
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "end while paused");

debug("<h3>Verify buffer is bound for transform feedback even when its active TF object is unbound (and paused)</h3>");

// 1. Create a buffer B and two transform feedback objects.
const bufB = createBuffer(gl, new Float32Array([0, 0]));
const local_tf1 = gl.createTransformFeedback();
const local_tf2 = gl.createTransformFeedback();

// 2. Bind local_tf1 and attach bufB to target index 0.
gl.bindTransformFeedback(gl.TRANSFORM_FEEDBACK, local_tf1);
gl.bindBufferBase(gl.TRANSFORM_FEEDBACK_BUFFER, 0, bufB);
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "attach bufB to local_tf1");

// 3. Begin transform feedback, then pause it. local_tf1 is now active+paused.
gl.beginTransformFeedback(gl.POINTS);
gl.pauseTransformFeedback();
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "local_tf1 is now active+paused");

// 4. Bind local_tf2. This unbinds local_tf1, but local_tf1 remains active+paused.
gl.bindTransformFeedback(gl.TRANSFORM_FEEDBACK, local_tf2);
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "switch binding to local_tf2; local_tf1 is unbound but still active+paused");

// 5. Try to modify bufB's data store (e.g., via gl.bufferData on another target like COPY_WRITE_BUFFER).
// Since bufB is still bound to the active local_tf1 (even though unbound and paused),
// modifying its data store is prohibited and MUST generate INVALID_OPERATION.
gl.bindBuffer(gl.COPY_WRITE_BUFFER, bufB);
gl.bufferData(gl.COPY_WRITE_BUFFER, 1024, gl.STATIC_DRAW);
wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION, "bufferData on a buffer currently bound to an active (but unbound and paused) transform feedback object must fail with INVALID_OPERATION");

// 6. Clean up: restore bindings, end transform feedback, and delete objects.
gl.bindBuffer(gl.COPY_WRITE_BUFFER, null);
gl.bindTransformFeedback(gl.TRANSFORM_FEEDBACK, local_tf1);
gl.endTransformFeedback();
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "end transform feedback on local_tf1");
gl.deleteTransformFeedback(local_tf1);
gl.deleteTransformFeedback(local_tf2);
gl.deleteBuffer(bufB);
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "clean up");

finishTest();

// Helper functions
Expand Down
Loading