Open
Conversation
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
noelherrick
reviewed
Apr 7, 2026
|
|
||
| // Delete Access and Refresh Tokens. | ||
| $settings = new ConvertKit_Settings(); | ||
| $settings->delete_credentials(); |
Contributor
There was a problem hiding this comment.
Would this delete all the keys such as CONVERTKIT_API_KEY? Are we storing those in the WordPress plugin?
Contributor
Author
There was a problem hiding this comment.
I've updated delete_credentials to also remove the API Key and Secret.
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the user clicks the
Disconnectbutton at Settings > Kit:oauth/revokeendpointTesting
testCredentialsAndResourcesAreDeletedOnDisconnect: end to end test confirming that the API Key, Secret, Access Token and Refresh Token are deleted from the Plugin.testCredentialsDeletedAndInvalidWhenRevoked: integration test confirming that the credentials are deleted from the Plugin and no longer work i.e. are revoked, when the API'srevoke_tokensmethod is called.Checklist