Open
Conversation
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Whenever a new Plugin release is published and the creator updates to the latest version, checks if a v3 API Secret exists, and if so deletes it from the Plugin's settings.
v3 API Keys and Secrets were retained following the introduction of the v4 API, to permit automatic exchange of v3 API Keys for v4 tokens. This was in July 2024, so by now the API secret isn't needed.
The v3 API Key is retained for the time being, to support legacy forms. A future PR will notify users who have this setting, and advise them how to add this to their
wp-config.phpfile.Testing
testV3APISecretRemovedFromSettings: Test that a v3 API Secret is removed from the Plugin's settings when specified.Checklist