Repository navigation
fix(cli): show the platform's default watch settle time - #563
Merged
KnifeLemon merged 1 commit intoOct 25, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrow implementation matches the stated purpose, includes focused regression coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
This focused fix makes CLI watch help report the watcher’s actual platform default settle time without changing watch behavior or adding localization.
Changes:
- Read the default from
FolderWatcher.DefaultSettleTimeusing invariant numeric formatting. - Add regression coverage for all three watch-help forms, including checks that help does not initialize engines.
| File | Description |
|---|---|
| tests/Filee.Cli.Tests/HelpTests.cs | Tests the platform default and engine-free help handling. |
| src/Filee.Cli/Help.cs | Replaces the hardcoded settle time with the watcher’s default. |
Review effort: Balanced
KnifeLemon
approved these changes
Oct 25, 2026
KnifeLemon
left a comment
Owner
There was a problem hiding this comment.
Thanks @Blackspirits! This is exactly the small standalone fix we hoped for from #552: the help now reads the same FolderWatcher.DefaultSettleTime the watcher falls back to, so Linux and macOS show 5 and Windows shows 2, and the tests also make sure help never initializes engines. It can be merged once CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
filee watch --helpalways says the default settle time is 2 seconds, but the watcher actually waits 5 seconds on Linux and macOS. Read the value fromFolderWatcher.DefaultSettleTimeso the help matches the running platform, using invariant numeric formatting.This is the small standalone fix suggested in #552. It does not change watch behavior or add CLI localization.
Type of change
How was it tested?
FILEE_DATA_DIR: 30 passed, 0 failed, 1 skipped (existing case-sensitive-volume requirement).help watch,watch --helpandwatch -h, checking the platform default and that help never initializes engines.default 2, returning 0 and leaving the isolated profile absent.git diff --checkpass. CI is pending for Linux/macOS execution and the full repository checks.Without
FILEE_DATA_DIRisolation, an existing JPEG XR listing assertion failed on this machine. The same test fails on unmodified main1bf94e71, and the actualformats jxroutput is identical before and after this patch. Isolating the engine download directory resolves it; no existing test or skip was changed.Checklist
No graphical interface changes.