[adnan-bhaldar]

Tip

Start the title with a prefix so the PR is labeled automatically: feat: fix: docs: ci: build: i18n:
Example: fix(hwp): keep tables when converting to DOCX

What does this change?

Fixes two places where the selected or hovered row highlight looked wrong. This is the smaller follow-up to the closed scrollbar PR, as suggested in its review. Only src/Filee.App/Styles/Soft.axaml changes, and the scrollbar itself is untouched.

Follow-up to #568

• Lists (ListBox.soft, e.g. Presets): the selected or hovered row used to run underneath the floating scrollbar. Each row now keeps 16px free on its right, so the highlight ends before the scrollbar. The scrollbar still behaves as before (thin at rest, wider on hover).
• Dropdowns (ComboBox): the same fix for the dropdown rows, for example "Convert to". The rows are also rounded and inset inside the popup, so the selected or hovered row no longer pokes out of the rounded corners. The popup uses SoftRadius and the rows use SoftRadiusSmall, so both follow the Softness setting, down to sharp corners.
• The Material You popup's shadow is unchanged. I did not add ClipToBounds. The Material You ComboBox popup and item styles got the same spacing edit, because they are more specific and would otherwise override it.

Side effect: because the rows leave room for the scrollbar, short lists and dropdowns without a scrollbar show a slightly wider gap on the right of the highlight than on the left.

Type of change

• Bug fix
• New feature or improvement
• New format or engine
• Translation
• Documentation
• Build, CI or dependencies

How was it tested?

• dotnet format --verify-no-changes
• dotnet test
• Tried it in the app (what you converted or clicked, and on which OS):

Screenshots (UI changes)

Checklist

• New UI strings are in all src/Filee.App/Assets/i18n/*.json files (no new strings)
• New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md (none added)
• The PR does one thing (unrelated changes go in a separate PR)

[KnifeLemon]

Thanks @adnan-bhaldar for splitting this out of #568. The scope is just what we talked about, and the Material You popup keeps its shadow.

CI fails on one test, MaterialYouThemeTests.Plain_buttons_are_the_surface_with_a_border_unlike_a_disabled_box, in the Windows build and both Linux portable jobs; the two "Package on Ubuntu 22.04" jobs fail only because the portable artifacts they need weren't produced. The commit deletes the twelve ButtonBackground* / ButtonBorderBrush* brushes from the Light and Dark dictionaries at the top of Soft.axaml, the ones #524 (#570) added for plain buttons. It looks like an older copy of the file slipped in while editing, so plain buttons went back to Fluent's grey. Please restore that block from main, and the test passes again.

Two small things:

• fixes #568 in the description points at the closed PR, so it won't link anything useful. "Follow-up to #568" says it better.
• Please tick what you ran under "How was it tested?" and add before/after screenshots in the normal look and in Material You: the Presets list with a scrollbar, a long dropdown (Convert to), and a short dropdown without a scrollbar. The short one is where the right margin shows, so I'd like to see how the gap looks there.

[adnan-bhaldar]

Thanks for the review, @KnifeLemon and sorry about that. I built the file from an older copy of Soft.axaml, which is why the ButtonBackground* / ButtonBorderBrush* brushes from #570 went missing.

I've restored all twelve (Light and Dark) from main and pushed. I checked git diff upstream/main -- src/Filee.App/Styles/Soft.axaml, and it now shows only the list and dropdown changes. CI should confirm MaterialYouThemeTests passes again.

Also done:

• Changed the description to "Follow-up to Add slim accent scrollbar styles and themes for improved UI consistency #568".
• Ticked what I ran under "How was it tested?".
• Added before/after screenshots in the normal look and in Material You: the Presets list with a scrollbar, a long dropdown (Convert to), and a short dropdown without a scrollbar (Rotate), so you can see how the gap looks there.

Screenshots (UI changes)

Normal look

	Before	After
Presets list with a scrollbar
Long dropdown with a scrollbar (Convert to)
Short dropdown without a scrollbar (Rotate)

Material You

	Before	After
Presets list with a scrollbar
Long dropdown with a scrollbar (Convert to)
Short dropdown without a scrollbar (Rotate)

[KnifeLemon]

Thanks @adnan-bhaldar, 86c3576 brings the twelve button brushes back, so the Material You test should pass again (CI is still running).

Two things left before it can go in:

• The before/after screenshots from the review: normal look and Material You, the Presets list with a scrollbar, a long dropdown (Convert to) and a short one without a scrollbar. The short one shows the wider right gap, which is the part I'd like to see. The "Tried it in the app" line still has the template's placeholder; please say what you clicked and on which OS.
• Small: the commit also re-indents xmlns:x on line 9 of Soft.axaml. Please put it back so the diff stays on the styles.