Skip to content

fix: Added changes to handle headers as case-insensitive#298

Merged
shivaygupta-dotcom merged 1 commit into
mainfrom
fix/header-case-handling
Jun 12, 2026
Merged

fix: Added changes to handle headers as case-insensitive#298
shivaygupta-dotcom merged 1 commit into
mainfrom
fix/header-case-handling

Conversation

@shivaygupta-dotcom

@shivaygupta-dotcom shivaygupta-dotcom commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

GH: Kong/deck#2080

Fixed three corner cases in header-based routing.
When a header's enum had duplicate values differing only by case (e.g. us-east vs US-EAST), or the same header was defined twice with different casing (e.g. X-Env and x-env), decK was generating redundant or conflicting routes.

We now normalize and deduplicate header names and values, merge same-header definitions, and filter out empty string enum values — resulting in cleaner and more predictable route generation

slack thread: https://kongstrong.slack.com/archives/C04349E4KRC/p1779423079760519

@shivaygupta-dotcom shivaygupta-dotcom force-pushed the fix/header-case-handling branch from e0f0a81 to aebcff3 Compare June 10, 2026 06:19
@codecov-commenter

codecov-commenter commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.50%. Comparing base (04e8549) to head (f026624).

Files with missing lines Patch % Lines
openapi2kong/openapi2kong.go 90.90% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   65.07%   65.50%   +0.43%     
==========================================
  Files          25       25              
  Lines        3204     3256      +52     
==========================================
+ Hits         2085     2133      +48     
- Misses        905      907       +2     
- Partials      214      216       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shivaygupta-dotcom shivaygupta-dotcom marked this pull request as ready for review June 10, 2026 08:32
@shivaygupta-dotcom shivaygupta-dotcom marked this pull request as draft June 10, 2026 08:32
@shivaygupta-dotcom shivaygupta-dotcom marked this pull request as ready for review June 10, 2026 08:56
@shivaygupta-dotcom shivaygupta-dotcom force-pushed the fix/header-case-handling branch from aebcff3 to f026624 Compare June 10, 2026 08:57
@shivaygupta-dotcom shivaygupta-dotcom merged commit 7dc971f into main Jun 12, 2026
5 checks passed
@shivaygupta-dotcom shivaygupta-dotcom deleted the fix/header-case-handling branch June 12, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants