Skip to content

Add column selector overloads for GroupBy.sortByKey #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add column selector overloads for GroupBy.sortByKey #1768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/sort.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import org.jetbrains.kotlinx.dataframe.DataColumn
import org.jetbrains.kotlinx.dataframe.DataFrame
import org.jetbrains.kotlinx.dataframe.DataFrameExpression
import org.jetbrains.kotlinx.dataframe.DataRow
import org.jetbrains.kotlinx.dataframe.ColumnsSelector
import org.jetbrains.kotlinx.dataframe.Selector
import org.jetbrains.kotlinx.dataframe.annotations.AccessApiOverload
import org.jetbrains.kotlinx.dataframe.columns.ColumnGroup
Expand Down Expand Up @@ -220,4 +221,14 @@ public fun <T, G> GroupBy<T, G>.sortByKey(nullsLast: Boolean = false): GroupBy<T
.sortBy { keys.columns().toColumnSet().nullsLast(nullsLast) }
.asGroupBy(groups)

public fun <T, G, C> GroupBy<T, G>.sortByKey(columns: ColumnsSelector<T, C>): GroupBy<T, G> =
toDataFrame()
.sortBy { columns.toColumnSet() }
.asGroupBy(groups)

public fun <T, G, C> GroupBy<T, G>.sortByKeyDesc(columns: ColumnsSelector<T, C>): GroupBy<T, G> =
toDataFrame()
.sortBy { columns.toColumnSet().desc() }
.asGroupBy(groups)

// endregion