fix(filters): unified 34px height for all filter controls across pages#1192
Open
efiten wants to merge 1 commit into
Open
fix(filters): unified 34px height for all filter controls across pages#1192efiten wants to merge 1 commit into
efiten wants to merge 1 commit into
Conversation
…pages
The global `select { min-height: 48px }` touch-target rule was taller than
the 34px custom dropdown buttons, causing visual inconsistency on the packets,
analytics, and nodes pages.
- .filter-bar input/select: add min-height:34px (packets page, sort select)
- .nodes-filters select: add height+min-height:34px (nodes page)
- analytics: replace .time-window-filter+label with .analytics-filters flex
row and .analytics-time-window-select styled to match region dropdown buttons
- .analytics-filters: flex row so region filter and time-window sit side by side
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
efiten
added a commit
to efiten/meshcore-analyzer
that referenced
this pull request
May 12, 2026
…ects Backport of PR Kpa-clawbot#1192: adds min-height:34px to .filter-bar input/select and height+min-height to .nodes-filters select, overriding the global select{min-height:48px} touch-target rule. Analytics fix already present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The global
select { min-height: 48px }touch-target rule was taller than the 34px custom dropdown buttons (region filter, multi-select dropdowns), causing visible height inconsistency on the packets, analytics, and nodes pages..filter-bar input/select— addmin-height: 34pxto match existingheight: 34px(packets page: time window, channel, sort selects and text inputs).nodes-filters select— addheight: 34px; min-height: 34px(nodes page: last-heard select).time-window-filter+ label with.analytics-filtersflex row; style#analyticsTimeWindowwith.analytics-time-window-selectto match region dropdown button height and appearanceSupersedes #1191 (which only fixed the analytics case).
Test plan
🤖 Generated with Claude Code