Repository navigation
chore: the last fc/_fc_/FC_ names take the Pace spelling - #1715
Merged
Merged
Conversation
The rename to Pace (#1714) moved this module's cache variables and environment variables to PACE_*, but left its private functions and variables on the old `_fc_` prefix. They are now `_pace_`, the prefix cmake/ErrorPopups.cmake already uses for the same purpose, and every script check that calls or reads one (debug-prefix-map-rules, pace-addr-opt-out, version-fallback-warning, compile-cache-dispatch, the daemon staging/diagnostic/start checks) and every rulebook or code comment that cites one follows. `_fc_pace_env` becomes `_pace_launcher_env` rather than the stuttering `_pace_pace_env`, and a comment naming `_fc_auto_start_fastached` -- a function that never existed under that spelling -- now names `_pace_auto_start_pace_kv`. The `/mnt/d/fastcached/...` measurement on line 92 stays: brand-leftovers exempts it as a quotation. The other `_fc_` names in the tree (the pace-cc and pace-node target lists, test-local variables, the macOS account helper) are not this module's and are left for their own change. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
christianparpart
added
the
type/chore
github-actions
Bot
added
area/launcher
The previous commit renamed cmake/portable/CompileCache.cmake's private symbols; this one finishes the job for every other `_fc_` name in the tree, so none is left: - the launcher's source lists `_fc_cc_core` and `_fc_cc_sources` (and its zstd/lz4 link variables), `_fc_node_shared`, `_fc_cli_sources` and `_fc_cli_tui_tests`, and Pace's own `_fc_zstd_target`/`_fc_lz4_target`; - the test-registration locals in src/tests/CMakeLists.txt; - `_fc_decode` in check-wix-service-table.cmake, the wrapper's shell variables in launcher-replay-e2e.sh and the macOS account helper's; - every comment, rulebook line, AGENT.md and source-map entry and plan that cites one of them. Each takes `_pace_`, and none collides with an existing name. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
github-actions
Bot
added
area/compile-cache
The last of the old abbreviation, so none of the three spellings is left in a first-party file: - FC_ becomes PACE_: the TLS, compression and ranges-fallback compile definitions, the test stubs' and fixtures' environment variables, and script placeholders. Two compile definitions take a _PATH suffix, PACE_SYSCONF_PATH and PACE_MACOS_PREFIX_PATH, because PACE_SYSCONF_DIR and PACE_MACOS_PREFIX are already the CMake settings they are derived from, holding the same path WITHOUT its leading slash -- one name for two values is the confusion a rename should not introduce. - The profiling docs named FC_ZONE_SCOPED and friends in Pace/Core/Profiling.hpp, a header that no longer exists. They now name what the code uses: core-cpp's CORE_* macros in <core/Profiling.hpp>. AGENT.md keeps its line count. - fc_ helper functions in the check scripts become pace_; each is local to its own cmake -P script, so the existing pace_case and pace_stage elsewhere do not collide. - fc- becomes pace-: the Tracy thread labels (pace-admin, pace-reactor-N, pace-acceptor-N -- a profiler label, never pthread_setname_np, so Linux's 15-byte limit does not apply), test scratch names, the marker probe (and its upper-case spelling in the case-insensitivity test), and CI and bench temp paths. Bare `fc` is left alone: there it is the byte 0xFC, the compiler flag -fc++-static-destructors, a container name or a bench local. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
christianparpart
changed the title
github-actions
Bot
added
area/cluster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1714. The rename moved the user-facing names to Pace but left the old
fcabbreviation in private symbols, compile definitions, test fixtures and thread labels. After this PR no first-party file spells_fc_,fc_,FC_orfc-.Commits
cmake/portable/CompileCache.cmake's private symbols (_fc_*→_pace_*, the prefixcmake/ErrorPopups.cmakealready uses), plus every script check and rulebook line that calls or cites one._fc_pace_env→_pace_launcher_env. A comment naming the nonexistent_fc_auto_start_fastachednow names_pace_auto_start_pace_kv._fc_name:_pace_cc_core,_pace_cc_sources,_pace_node_shared,_pace_cli_sources, the zstd/lz4 target variables, test-registration locals,_pace_decode, and the shell locals in the macOS account helper and the launcher-replay wrapper.FC_/fc_/fc-:FC_*→PACE_*(TLS, compression and ranges-fallback compile definitions, test environment variables, stubs).FC_SYSCONF_DIR→PACE_SYSCONF_PATHandFC_MACOS_PREFIX→PACE_MACOS_PREFIX_PATH, because the plainPACE_names are already the CMake settings they derive from, holding a different value (no leading/).FC_ZONE_SCOPEDand friends inPace/Core/Profiling.hpp, which no longer exists. They now cite core-cpp'sCORE_*macros in<core/Profiling.hpp>.fc_script helpers →pace_.fc-→pace-for Tracy thread labels, test scratch names, the marker probe and CI/bench temp paths.Kept:
/mnt/d/fastcached/...inCompileCache.cmake, an exempted quotation. Barefcwhere it means the byte0xFC,-fc++-static-destructors, a container name or a bench local.Verified locally (Windows, MSVC 19.5x, Ninja)
build.ninjacarries the new definitions and noFC_.ctest: 6827/6833 pass. Of the 6 failures, one was this change (-DFC_ROLEinversion-git-unanswered, fixed and re-run green). The other five are this host:control-bytes: a CRLF working tree. The diff carries no CR.mkdocs-validation,pacectl-e2e:python3is the Microsoft Store stub.launcher-e2e-ports-selftest: its walk reaches a stale local.claude/worktrees/probe-werrorcopy. This branch's file scores 0.agent-md-budget,rulebook-tripwires,table-totalspass.e2e-helpers-selftestfails the same 2 cases on master here.