fix Activity 4 preset unlock and take duration display#160
Merged
mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom Apr 2, 2026
Merged
fix Activity 4 preset unlock and take duration display#160mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom
mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom
Conversation
Applying an EQ preset now also logs effect_applied so it counts toward the Activity 4 requirement (3 effect uses). Duration resolution in TakesImportModal now uses fetch+decode for proxy/HTTP URLs (Audio element needs range-request support that the proxy doesn't provide). Added onerror handler and cleanup for blob URL fallback. Removed per-render console spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effect_applied, so presets count toward Activity 4's 3-effect requirementfetch+decodeAudioDatafor proxy/HTTP URLs instead of<audio>element (which needs range-request support the proxy lacks)onerrorhandlers and cleanup for blob URL duration resolution