Skip to content

let API pull in google dependencies #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
labkey-matthewb wants to merge 2 commits into from
Closed

let API pull in google dependencies #414

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c24e859
let API pull in google dependencies
labkey-matthewb Jan 20, 2026
307eac5
let's try "force" instead of "exclude"
labkey-matthewb Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions SequenceAnalysis/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ dependencies {
exclude group: "org.apache.commons", module: "commons-collections4"
// NOTE: this is a dependency of picard->google-cloud-storage. there is a vunerability in 1.6.8 that does not seem fixed as of 1.6.9
exclude group: "org.threeten", module: "threetenbp"
// google-genai dependencies in API pull in newer versions of these modules
exclude group: "com.google.api", module : "api-common"
exclude group: "com.google.auth", module : "google-auth-library-oauth2-http"
exclude group: "com.google.auth", module : "google-auth-library-credentials"
Copy link
Copy Markdown

@labkey-susanh labkey-susanh Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since those are being pulled in from API, this is probably ok. Usually we go the route of forcing a particular version of dependencies when there's a conflict. It allows the dependency to come through to the module without relying on the presence of the other module (though, of course, for API it will always be there), but it also can result in duplicate (transitive) dependencies, so it's a bit of a tradeoff.

}
)

Expand Down