-
Notifications
You must be signed in to change notification settings - Fork 1
Add an upgrade script to assign correct types to createdBy, modifiedBy, and container columns #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
labkey-bpatel
merged 3 commits into
release25.11-SNAPSHOT
from
25.11_fb_update_type_int2_to_userid
Feb 20, 2026
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| Name: OConnor | ||
| SchemaVersion: 25.001 | ||
| SchemaVersion: 26.001 | ||
| RequiredServerVersion: 16.30 | ||
| ManageVersion: true |
65 changes: 65 additions & 0 deletions
65
OConnor/resources/schemas/dbscripts/postgresql/oconnor-26.000-26.001.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| DO $$ | ||
| DECLARE | ||
| rec RECORD; | ||
| BEGIN | ||
| FOR rec IN | ||
| SELECT c.table_name, c.column_name | ||
| FROM information_schema.columns c | ||
| JOIN information_schema.tables t ON t.table_schema = c.table_schema AND t.table_name = c.table_name | ||
| WHERE c.table_schema = 'oconnor' | ||
| AND t.table_type = 'BASE TABLE' | ||
| AND lower(c.column_name) IN ('createdby', | ||
| 'modifiedby') | ||
| AND c.data_type = 'smallint' | ||
| LOOP | ||
| EXECUTE format( | ||
| 'ALTER TABLE oconnor.%I ALTER COLUMN %I | ||
| TYPE userid', | ||
| rec.table_name, rec.column_name | ||
| ); | ||
| END LOOP; | ||
| END $$; | ||
|
|
||
| DO $$ | ||
| DECLARE | ||
| rec RECORD; | ||
| view_rec RECORD; | ||
| BEGIN | ||
| -- Save view definitions and drop all views in oconnor schema to clear dependencies | ||
| CREATE TEMP TABLE _oconnor_view_defs (viewname text, definition text); | ||
|
|
||
| FOR view_rec IN | ||
| SELECT viewname, definition | ||
| FROM pg_views | ||
| WHERE schemaname = 'oconnor' | ||
| LOOP | ||
| INSERT INTO _oconnor_view_defs VALUES (view_rec.viewname, view_rec.definition); | ||
| EXECUTE format('DROP VIEW IF EXISTS oconnor.%I CASCADE', view_rec.viewname); | ||
| END LOOP; | ||
|
|
||
| -- Alter container columns on base tables | ||
| FOR rec IN | ||
| SELECT c.table_name, c.column_name | ||
| FROM information_schema.columns c | ||
| JOIN information_schema.tables t ON t.table_schema = c.table_schema AND t.table_name = c.table_name | ||
| WHERE c.table_schema = 'oconnor' | ||
| AND t.table_type = 'BASE TABLE' | ||
| AND lower(c.column_name) = 'container' | ||
| AND c.data_type = 'character varying' | ||
| LOOP | ||
| EXECUTE format( | ||
| 'ALTER TABLE oconnor.%I ALTER COLUMN %I | ||
| TYPE entityid', | ||
| rec.table_name, rec.column_name | ||
| ); | ||
| END LOOP; | ||
|
|
||
| -- Recreate views from saved definitions | ||
| FOR view_rec IN | ||
| SELECT viewname, definition FROM _oconnor_view_defs | ||
| LOOP | ||
| EXECUTE format('CREATE OR REPLACE VIEW oconnor.%I AS %s', view_rec.viewname, view_rec.definition); | ||
| END LOOP; | ||
|
|
||
| DROP TABLE _oconnor_view_defs; | ||
| END $$; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.