Skip to content

Commit 0371449

Browse files
committed
Use LOOKUP_DEFAULT_SIZE in various places for QuerySelect props
1 parent cee5a9f commit 0371449

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

packages/components/src/internal/components/forms/QueryFormInputs.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ import { TextChoiceInput } from './input/TextChoiceInput';
4242

4343
import { getQueryFormLabelFieldName, isQueryFormLabelField } from './utils';
4444
import { InternalSpacesWarning } from './InternalSpacesWarning';
45+
import { LOOKUP_DEFAULT_SIZE } from '../../constants';
4546

4647
export interface QueryFormInputsProps {
4748
allowFieldDisable?: boolean;
@@ -278,7 +279,7 @@ export class QueryFormInputs extends React.Component<QueryFormInputsProps, State
278279
joinValues={joinValues}
279280
label={col.caption}
280281
loadOnFocus
281-
maxRows={10}
282+
maxRows={LOOKUP_DEFAULT_SIZE}
282283
multiple={multiple}
283284
name={fieldKey}
284285
notFoundValuesEnabled={!(col.isExpInput() || col.isAliquotParent())} // Issue 53153

packages/components/src/internal/components/forms/detail/DetailDisplay.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import { ExpirationDateColumnRenderer } from '../../../renderers/ExpirationDateC
4141
import { getContainerFilterForLookups } from '../../../query/api';
4242
import { FolderColumnRenderer } from '../../../renderers/FolderColumnRenderer';
4343
import { FILELINK_RANGE_URI } from '../../domainproperties/constants';
44+
import { LOOKUP_DEFAULT_SIZE } from '../../../constants';
4445

4546
export type Renderer = (data: any, row?: any) => ReactNode;
4647

@@ -338,7 +339,7 @@ export function resolveDetailEditRenderer(
338339
joinValues={joinValues}
339340
key={col.fieldKey}
340341
label={col.caption}
341-
maxRows={10}
342+
maxRows={LOOKUP_DEFAULT_SIZE}
342343
multiple={multiple}
343344
name={col.fieldKey}
344345
notFoundValuesEnabled={!(col.isExpInput() || col.isAliquotParent())} // Issue 53153

packages/components/src/internal/components/labelPrinting/PrintLabelsModal.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import { BarTenderResponse } from './models';
1717
import { BAR_TENDER_TOPIC, LABEL_NOT_FOUND_ERROR, LABEL_TEMPLATE_SQ } from './constants';
1818
import { ViewInfo } from '../../ViewInfo';
1919
import { SchemaQuery } from '../../../public/SchemaQuery';
20+
import { LOOKUP_DEFAULT_SIZE } from '../../constants';
2021

2122
export interface PrintModalProps {
2223
afterPrint?: (numSamples: number, numLabels: number) => void;
@@ -239,7 +240,7 @@ export class PrintLabelsModalImpl extends PureComponent<PrintModalProps & Inject
239240
fireQSChangeOnInit={true}
240241
showLabel={false}
241242
loadOnFocus
242-
maxRows={10}
243+
maxRows={LOOKUP_DEFAULT_SIZE}
243244
multiple={true}
244245
name="label-samples"
245246
onQSChange={this.changeSampleSelection}
@@ -259,7 +260,7 @@ export class PrintLabelsModalImpl extends PureComponent<PrintModalProps & Inject
259260
fireQSChangeOnInit
260261
showLabel={false}
261262
loadOnFocus
262-
maxRows={10}
263+
maxRows={LOOKUP_DEFAULT_SIZE}
263264
name="label-template"
264265
onQSChange={this.changeTemplateSelection}
265266
placeholder="Select or type to search..."

0 commit comments

Comments
 (0)