Issue 53326: Don't filter QuerySelect in PrintLabelsModal (#1817)

Author: labkey-susanh

packages/components/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@labkey/components",
-  "version": "6.52.1",
+  "version": "6.52.2",
   "description": "Components, models, actions, and utility functions for LabKey applications and pages",
   "sideEffects": false,
   "files": [

packages/components/package.json

@@ -1,6 +1,11 @@
 # @labkey/components
 Components, models, actions, and utility functions for LabKey applications and pages
 
+### version 6.52.2
+*Released*: 27 June 2025
+- Issue 53326: Don't filter `QuerySelect` in `PrintLabelsModal`
+- Issue 53213: Defensive check for view `sorts` array
+
 ### version 6.52.1
 *Released*: 25 June 2025
 - Issue 53120: remove processRequest, use getCallbackWrapper

packages/components/releaseNotes/components.md

@@ -113,13 +113,13 @@ export class ViewInfo {
         const name_ = isDefault || name === undefined || name === '' ? ViewInfo.DEFAULT_NAME : name;
 
         return new ViewInfo({
+            ...rest,
             columns: columns !== undefined ? [...columns] : [],
             filters: getFiltersFromView(filter),
             isDefault,
             label: label_,
             name: name_,
             sorts: getSortsFromView(sort),
-            ...rest,
         });
     }
 

packages/components/src/internal/ViewInfo.ts

@@ -1,5 +1,4 @@
 import React, { PureComponent, ReactNode } from 'react';
-import { List } from 'immutable';
 
 import { Modal } from '../../Modal';
 import { ComponentsAPIWrapper, getDefaultAPIWrapper } from '../../APIWrapper';
@@ -223,7 +222,7 @@ export class PrintLabelsModalImpl extends PureComponent<PrintModalProps & Inject
                 <>
                     <div className="bottom-padding">{message}</div>
                     <div>
-                        <strong>Number of copies</strong>
+                        <label>Number of copies</label>
                         <input
                             className="form-control label-printing--copies"
                             min={1}
@@ -234,7 +233,7 @@ export class PrintLabelsModalImpl extends PureComponent<PrintModalProps & Inject
                         />
                         {showSelection && (
                             <div className="top-padding">
-                                <strong>Selected samples to print</strong>
+                                <label>Selected samples to print</label>
                                 <QuerySelect
                                     formsy={false}
                                     fireQSChangeOnInit={true}
@@ -247,15 +246,14 @@ export class PrintLabelsModalImpl extends PureComponent<PrintModalProps & Inject
                                     placeholder="Select or type to search..."
                                     required={false}
                                     schemaQuery={model.schemaQuery}
-                                    queryFilters={List(model.filters)}
                                     displayColumn={displayColumn}
                                     valueColumn={valueColumn}
                                     value={this.props.sampleIds?.join(',')}
                                 />
                             </div>
                         )}
                         <div className="top-padding">
-                            <strong>Label template</strong>
+                            <label>Label template</label>
                             <QuerySelect
                                 formsy={false}
                                 fireQSChangeOnInit

packages/components/src/internal/components/labelPrinting/PrintLabelsModal.tsx

@@ -20,7 +20,7 @@ export class BarTenderConfiguration implements BarTenderConfigurationModel {
     static create(config?: { defaultLabel: string; serviceURL: string }): BarTenderConfiguration {
         return new BarTenderConfiguration({
             serviceURL: config.serviceURL,
-            defaultLabel: parseInt(config.defaultLabel, 10),
+            defaultLabel: config.defaultLabel ? parseInt(config.defaultLabel, 10) : undefined,
         });
     }