Open
Conversation
…h the intention to remove some of the default or previously added more actions menu items for treatment_order. But it doesn't seem necessary. Also, its breaking the TC tests when both NIRC and TNPRC on postgres are present - TNPRC adds the menu item it needs during startup, and NIRC globally unregisters it causing TNPRC test failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Remove unregisterMoreActionsButtons() - previously added for NIRC with the intention to remove some of the default or previously added more actions menu items for treatment_order. But this is no longer needed. Also, its breaking the TC tests when both NIRC and TNPRC on postgres are present - TNPRC adds the menu item it needs during startup, and NIRC globally unregisters it causing TNPRC test failure.
Related Pull Requests
Changes