Use absolute URLs for Apache HTTP requests in crawler (#2397)

Author: labkey-tchad

src/org/labkey/test/WebTestHelper.java

@@ -355,6 +355,29 @@ public static String makeRelativeUrl(String url)
         return StringUtils.stripStart(url, "/");
     }
 
+    /**
+     * Append the test server's base URL to the front of a relative URL. Absolute URLs will be returned unchanged.
+     * @param url Absolute or relative URL
+     * @return Absolute URL
+     */
+    public static String makeAbsoluteUrl(String url)
+    {
+        if (isAbsoluteUrl(url))
+        {
+            return url;
+        }
+        else
+        {
+            StringBuilder sb = new StringBuilder(getBaseURL());
+            if (!url.startsWith("/"))
+            {
+                sb.append("/");
+            }
+            sb.append(url);
+            return sb.toString();
+        }
+    }
+
     public static boolean isAbsoluteUrl(String url)
     {
         return url.startsWith("http://") || url.startsWith("https://");

src/org/labkey/test/util/Crawler.java

@@ -1190,7 +1190,7 @@ else if (urlToCheck.isFromForm()) // Forms may 404 with bad input
 
     private boolean doesUrlExist(UrlToCheck urlToCheck)
     {
-        final String url = stripQueryParams(urlToCheck.getRelativeURL());
+        final String url = WebTestHelper.makeAbsoluteUrl(stripQueryParams(urlToCheck.getRelativeURL()));
 
         // Check whether 404 was due to a missing action
         HttpContext context = WebTestHelper.getBasicHttpContext();