More claude code review feedback.

Author: labkey-danield

src/org/labkey/test/TestFileUtils.java

@@ -450,8 +450,9 @@ public static void deleteDir(File dir)
      * Rename a directory.
      * @param sourceDir the directory to rename
      * @param newDirName the new name for the directory
+     * @return return the path to the renamed directory
      */
-    public static void renameDir(Path sourceDir, String newDirName) throws IOException
+    public static Path renameDir(Path sourceDir, String newDirName) throws IOException
     {
         LOG.info("Renaming {} to {}", sourceDir, newDirName);
 
@@ -465,7 +466,9 @@ public static void renameDir(Path sourceDir, String newDirName) throws IOExcepti
                 : Paths.get(newDirName);
         Files.move(sourceDir, newDir);
 
-        LOG.info("Rename successful.");
+        LOG.info("Renamed {} to {}", sourceDir, newDir);
+
+        return newDir;
     }
 
     private static void checkFileLocation(File file)

src/org/labkey/test/tests/assay/AssayTransformMissingParentDirTest.java

@@ -46,17 +46,20 @@ public void testMissingParentDirectoryRegression() throws Exception
         assayDesignerPage.goToBatchFields().removeAllFields(true);
         // add by path so the absolute path is stored; this allows reproducing the missing parent dir scenario
         assayDesignerPage.addTransformScript(transformFile);
-        getArtifactCollector().dumpPageSnapshot("TransformScript_Added");
         assayDesignerPage.clickSave();
 
-        // Now rename the parent dir to ensure we handle it reasonably. Deleting directories on Windows is not always
+        // Rename the parent dir to ensure we handle it reasonably. Deleting directories on Windows is not always
         // timely, renaming the directory will have the same effect.
         String newName = "Not-Here-" + UUID.randomUUID();
-        TestFileUtils.renameDir(parentDir, newName);
+        Path renamedDir = TestFileUtils.renameDir(parentDir, newName);
 
         Assert.assertFalse(String.format("Directory %s is still present.", parentDir),
                 FileUtils.isDirectory(parentDir.toFile()));
 
+        // Delete the renamed directory as a cleanup step. Since the directory has been renamed, the slow delete on Windows
+        // will not cause the test to fail.
+        TestFileUtils.deleteDir(renamedDir.toFile());
+
         // Attempt to import data and verify a reasonable error message is shown
         String importData = """
                 VisitID\tParticipantID\tComment
@@ -94,6 +97,7 @@ public void testMissingParentDirectoryRegression() throws Exception
 
         // Verify we land on the run details page and can see the run name (no transform needed)
         new AssayRunsPage(getDriver()).clickAssayIdLink("fixedAssayImport");
+
     }
 
 }