infra: add test, typecheck, and lint scripts#42
Open
gerani1 wants to merge 1 commit into
Open
Conversation
- Add `test` and `test:watch` scripts using Jest - Add `typecheck` script running `tsc --noEmit` - Update `lint` to run ESLint; move Prettier check to `lint:format` - Document all new scripts in README "Available Scripts" section Closes LabsCrypt#12
ogazboiz
requested changes
Jun 23, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
nice to get test/typecheck/lint scripts in, and the test/typecheck/lint:format ones are good (they run and match the real tooling). one thing to change:
- package.json:9 repoints the existing lint gate "lint": "prettier --check ." to "lint": "eslint .", but npm run lint now fails out of the box (42 eslint errors, all pre-existing on main and unfixed), so a fresh checkout has a red canonical lint command. please keep "lint": "prettier --check ." (that's the gate the repo uses) and expose eslint under a separate name, e.g. "lint:eslint": "eslint .". only flip lint -> eslint in the same PR that actually clears those 42 errors.
the README line advertising npm run lint as eslint should match whatever you land. otherwise solid, small PR.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testandtest:watchscripts using Jesttypecheckscript runningtsc --noEmitlintto run ESLint; move Prettier check tolint:formatCloses #12