Skip to content

fix: resolve assigned issues #1115, #1116, #1117, #1118#1119

Merged
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
codeX-james:fix/resolve-assigned-issues
Jun 27, 2026
Merged

fix: resolve assigned issues #1115, #1116, #1117, #1118#1119
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
codeX-james:fix/resolve-assigned-issues

Conversation

@codeX-james

Copy link
Copy Markdown
Contributor

Summary

Closes #1115
Closes #1116
Closes #1117
Closes #1118

Test plan

  • Verify frontend/Dockerfile builds successfully and the runner stage runs as appuser (non-root)
  • Verify HEALTHCHECK passes when the frontend is running
  • Run cargo test in contracts/loan_manager — new oracle tests should pass
  • Verify env-docs-check CI passes with the new vars in both ENVIRONMENT.md and .env.example
  • Confirm the webhook signature verification snippet in docs/webhooks.md matches docs/wiki/webhook-signatures.md and the actual server behavior in webhookService.ts

…absCrypt#1118

Closes LabsCrypt#1115
Closes LabsCrypt#1116
Closes LabsCrypt#1117
Closes LabsCrypt#1118

- Frontend Dockerfile: use production-only deps, add non-root user, add HEALTHCHECK
- Oracle tests: add MockRateOracle contract and exercise the oracle interest-rate
  code path including in-bounds, below-min, above-max, get/set, and event emission
- ENVIRONMENT.md: document ADMIN_WALLETS, LENDER_WALLETS, EXPOSE_STACK_TRACES,
  JWT_COOKIE_NAME; add them to .env.example for CI drift check
- webhooks.md: fix signature docs to match actual sha256=<hex> header format,
  correct secret source to per-subscription secret, align with webhook-signatures.md
@ogazboiz ogazboiz merged commit b465a9f into LabsCrypt:main Jun 27, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment