docs(readme): align quick contribution guide with Conventional Commit…#1264
Merged
ogazboiz merged 1 commit intoJun 27, 2026
Merged
Conversation
…s and branch naming
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(frontend, docs): accessible LanguageSwitcher, AbortSignal forwarding, ENVIRONMENT.md source fixes, and useTransaction selector perf
Summary
This PR bundles four related frontend/docs hardening fixes that came out of the same accessibility/performance/documentation sweep:
Closes #1229) — the languageselectnow exposes a programmatic accessible name (aria-label="Language"), and the decorativeLanguagesicon is markedaria-hiddenso screen readers no longer announce an unlabeled combobox (WCAG 4.1.2 / 1.3.1).apiFetchAbortSignal forwarding (Closes #1221) —apiFetchnow accepts an optionalsignal?: AbortSignalthat is passed intofetch(), and query functions forward TanStack Query'scontext.signal. Navigating away / refetching andqueryClient.cancelQueriesin optimistic mutations now actually abort in-flight requests.Closes #1210) — corrected theSourcecolumn for backend variables to point at the real files (config/loanConfig.ts,config/stellar.ts,config/env.ts,config/sentry.ts, …) instead of non-existent paths.useTransactionstore selector (Closes #1223) —useTransactionnow selects onlytransactions[id]plus the specific stable action references it needs, instead of subscribing to the whole OptimisticUI store, eliminating re-renders of every consumer on unrelated transaction updates and droppingstorefrom the auto-dismiss effect deps.Also tidied the README Quick Contribution Guide so its branch-name and commit examples match the Conventional Commits + branch-naming conventions in
CONTRIBUTING.md.Linked Issues
Closes #1229
Closes #1221
Closes #1210
Closes #1223
Files Touched
frontend/src/app/components/global_ui/LanguageSwitcher.tsxfrontend/src/app/hooks/useApi.tsdocs/ENVIRONMENT.mdfrontend/src/app/hooks/useOptimisticUI.tsREADME.mdTesting
frontend:npm run lintandnpm run testpass; added a test querying the language control by accessible role/name to verify the accessible name.Sourcepath indocs/ENVIRONMENT.mdresolves to an existing file.Checklist
Out of Scope
AbortController([Frontend] apiFetch ignores TanStack Query's AbortSignal, so query cancellation and onMutate cancelQueries never abort in-flight requests #1221).