Skip to content

Update CNPJ check digits exception message terminology - #60

Merged
juliolmuller merged 1 commit into
mainfrom
fix/error-msg
Jun 27, 2026
Merged

Update CNPJ check digits exception message terminology#60
juliolmuller merged 1 commit into
mainfrom
fix/error-msg

Conversation

@juliolmuller

@juliolmuller juliolmuller commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Refined an input-length error message to use clearer, more consistent wording.
    • Updated related validation messaging so length mismatches are described in terms of characters rather than digits.

Fix as per @coderabbitai review comment at LacusSolutions/br-utils-py#55 (comment).

Co-authored-by: CodeRabbit AI <support@coderabbit.ai>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@juliolmuller
juliolmuller requested a review from a team as a code owner June 27, 2026 05:50
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The exception message in CnpjCheckDigitsInputLengthException changes the word "digits" to "characters". The test assertion and changelog entry are updated to match.

CNPJ Exception Message Wording

Layer / File(s) Summary
Exception message, test, and changelog
packages/cnpj-dv/src/Exceptions/CnpjCheckDigitsInputLengthException.php, packages/cnpj-dv/tests/specs/Exceptions.spec.php, packages/cnpj-dv/CHANGELOG.md
Exception message text changes from "digits" to "characters"; test expected string and changelog entry updated accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hopped through code one day,
Found "digits" where "characters" ought to stay.
One word swapped, the test agreed,
The changelog noted this tiny deed.
🐇 Small fixes matter too, indeed!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: updating the CNPJ check-digits exception message terminology.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/error-msg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@juliolmuller

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot changed the title @coderabbitai Update CNPJ check digits exception message terminology Jun 27, 2026
@juliolmuller
juliolmuller merged commit 5cec274 into main Jun 27, 2026
101 checks passed
@juliolmuller
juliolmuller deleted the fix/error-msg branch June 27, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant