feat(harvester): full implementation with cooldown enforcement and fuzz tests [GF-05]#60
Merged
wumibals merged 1 commit intoJun 23, 2026
Conversation
…tests Implements GF-05 as specified in issue LadderMine#38: - Cooldown enforced via env.ledger().sequence() (audit fix L-02) - 10 bps bounty to caller via checked multiplication - Remainder forwarded to StrategyVault - Zero-yield harvest handled gracefully - Property tests verify bounty + remainder == harvested for all inputs
|
@yusuftomilola is attempting to deploy a commit to the wumibals' projects Team on Vercel. A member of the Team first needs to authorize it. |
wumibals
approved these changes
Jun 23, 2026
wumibals
left a comment
wumibals
left a comment
Contributor
There was a problem hiding this comment.
I like the way you think.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the permissionless Harvester contract as specified in issue #38.
env.ledger().sequence()(ledger sequence, not timestamp) to fix audit finding L-02StrategyVaultviadeposit_capitalLAST_HARVEST_LEDGERwithout panicking or transferringbounty + remainder == harvestedfor all valid inputs, including boundary amounts and theu32::MAXcooldown overflow caseChanges
contracts/harvester/src/lib.rs— full implementation replacing the empty stubCloses #38